search

andalisolutions / anaf-php

ANAF PHP is a free PHP API client that allows you to interact with the ANAF Web Services.
MIT License
70 stars 17 forks source link

fix: TaxIdentificationNumberNotFoundException n/a anymore #31

Closed robert-stanciu closed 5 months ago

robert-stanciu commented 6 months ago

I believe the TaxIdentificationNumberNotFoundException exception is not needed anymore in HttpTransporter because it conflicts with Anaf\Resources\Info::create().

E.g. I am Anaf\Resources\Info::create() with multiple cuis and if one of them is present in the notFound array but the rest of them are found, I still get the TaxIdentificationNumberNotFoundException.

ciungulete commented 6 months ago

Yes, it was present when the package only functioned for one cui. I concur with your pull request, however, please review it again to eliminate the TaxIdentificationNumberNotFoundException and the commented-out code.

robert-stanciu commented 5 months ago

Hi @ciungulete, sorry for the delay, I got busy hehe.