andan67 / wormnav

Track navigation for Garmin watches
https://andan67.github.io/wormnav/
GNU General Public License v3.0
16 stars 7 forks source link

Spanish translation review #8

Closed alsama closed 3 years ago

alsama commented 3 years ago

In spanish translation of "dm_labels" in some cases is better to use the word "Lap" for "vueltas" texts as is smaller and fits better in data screens. I attach and image. wormnav_texts_01

andan67 commented 3 years ago

In the latest commit https://github.com/andan67/wormnav/commit/23c2813360782f690bfda6271b57a332a3b407eb I've set all data field labels as they appear on my FR 235 for the native apps. Additionally, I've also fixed a stupid bug which resulted in too large font size for vivoactive devices.

With these changes, the data screen layout looks OK for my FR 235 (all labels in all supported languages fit nicely into the fields).

However, when running as vivoactive 3 app in the simulator there are still layout issues that are aparently caused by a larger minimum font size compared to the FR 235. So I guess that the vivoactive 3 device uses different data labels than the FR 235.

Unfortunatly, there seems to be no available list of the data field labels as they appear on the screen. The user guides generally show different labels.

I undestand that you own a vivoactive 3 device. Thus it would be great if you could check the data screen layout of the current version and let me know which data field labels are displayed on your device for native apps.

I still aim at using data field labels that are as consistent as possible with the native ones.

andan67 commented 3 years ago

I've just found out that the labels for non-Englich languages can be easily extrcted from the language files stored on the device in the GARMIN/TXT folder. So it would be great if you could send me these files from your VA3 device. Thanks

alsama commented 3 years ago

Text folder in my va3 (firmware version 7.70):

TEXT.zip

In general word "vuelta" is used for "Lap" but sometimes "Lap" word is used too. For example: 01378 Auto Lap 02478 hasta pulsar Lap

In general "lap" term is quite common in spanish language in sports world. And because there is not too much space in data screen I think that is better use "Lap" word instead "vuelta".

alsama commented 3 years ago

I have tested commit 23c2813 and I think that "Graphics.FONT_XTINY" is too small to use in a label for a data screen. I attach an image:

wormnav_texts_03

Left: commit 23c2813 (using Graphics.FONT_XTINY). Center: Older version translated to spanish using "Lap" word for "vuelta" (using Graphics.FONT_SMALL). Right: Standard 4 fields screen in va3.

I think that standar labels in va3 are using "Graphics.FONT_SMALL" font.

You can see it in "devices.xml" in SDK 3.1.6. For va3:

All languages use font_set="ww" FNT_NOTO_SANS_BOLD_16PX FNT_NOTO_SANS_BOLD_22PX FNT_NOTO_SANS_BOLD_22PX FNT_NOTO_SANS_BOLD_25PX FNT_NOTO_SANS_BOLD_25PX FNT_NOTO_SANS_BOLD_29PX FNT_NOTO_SANS_BOLD_NMBR_48PX FNT_NOTO_SANS_BOLD_NMBR_76PX FNT_NOTO_SANS_BOLD_NMBR_94PX FNT_NOTO_SANS_BOLD_16PX FNT_NOTO_SANS_BOLD_22PX FNT_NOTO_SANS_BOLD_22PX FNT_NOTO_SANS_BOLD_25PX FNT_NOTO_SANS_BOLD_25PX FNT_NOTO_SANS_BOLD_29PX FNT_NOTO_SANS_BOLD_NMBR_48PX FNT_NOTO_SANS_BOLD_NMBR_76PX FNT_NOTO_SANS_BOLD_NMBR_94PX And 4 fields layout use labelfont="small": I attach devices.XML from SDK 3.1.6: [devices.xml.zip](https://github.com/andan67/wormnav/files/6330192/devices.xml.zip)
andan67 commented 3 years ago

Thanks for the languages files and the additional information. I've noticed that the vivoactive 3 device seems to be special regarding data screen layout and available fonts, which makes a 'generic' layout calculation a bit more difficult.

In the latest commit I've changed all data field lables according to the language files (using their shortest version). I've also changed the data screen layout and used your idea of setting on offset. For me, the layout now looks 'good enough' for all supported languages with standard data field names.

It would be great if you could let me know your thoughts on the changes.

alsama commented 3 years ago

I think that layout is better now because all fields are near center and so labels have more free space than near the top. Also the new label texts looks good. Using "vue" or "vuel." instead "lap" is good too. And using that labels I think that is possible use to use "Graphics.FONT_SMALL" font. And that have several adventages.

I put some photos of both options in my va3: wormnav_texts_05 wormnav_texts_06