andau / abapCI

Continuous Integration for ABAP

MIT License

62 stars 14 forks source link

FeatureRequest - Formatter #20

Closed zapik closed 5 years ago

zapik commented 5 years ago

Hello,

it would be great to have some formatter/beautifier that could enforce custom rules to solve formatting discrepancies in team (like indentation of IF's, method calls etc.) ? Or are you aware about such tool?

autoformat is nice, but Pretty Print is unfortunately not so powerful...

Feel free to close this as it not real issue :)

fabianlupa commented 5 years ago

I started implementing this over here: prettier-printer It is however quite difficult, especially because of things like chained statements, comments inside of statements between tokens, pragmas, statements spanning across multiple lines etc...

I might get back to it in the future but currently it is on hold.

larshp commented 5 years ago

Shift + F1 upper casing keywords implemented in https://marketplace.visualstudio.com/items?itemName=larshp.vscode-abaplint

andau commented 5 years ago

No I am not aware of such a tool, but I will let the issue open, maybe there are some further projects mentioned beside the two above.

kjetil-kilhavn commented 5 years ago

If someone on your team does not use abapCI or even Eclipse (yes, believe it or not ... they exist) such a feature here will not help you. If you want to be strict about it you can implement your own code inspector checks and prevent release of the transport until the checks are flawless. Then you don't have to worry about token analysis, it's already done for you. Not saying I would recommend this approach, just mentioning it.

larshp commented 5 years ago

code inspector check for pretty printer use, https://docs.abapopenchecks.org/checks/06/