anddea / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
574 stars 41 forks source link

bug: Revancify settings character limit. #247

Closed aqtoo closed 6 months ago

aqtoo commented 6 months ago

Type

Error while patching

Tools used

Revancify

Application

Revancify as of 02.04.2024 (DD/MM/YYYY)

Bug description

When reading the patch settings for "Tuck away preferences" it can't fit all it's default options in, hitting some form of character limit. Screenshot_20240402-015157_Termux

Leaving it cut off as "Try ex-"

Error logs

N/A

Solution

I'd suggest treating this patch like the edit account menu button. Placing the default list in there and letting users add their own that way. Instead just asking to restart the app instead of entirely patching. Screenshot_20240402-015356_YouTube RVX

Additional context

No response

Device Environment

Android 14, Termux Monet as recommended by revancify.

Acknowledgements

anddea commented 6 months ago

It's not possible to make it inside Extended preferences yet, because litho filter doesn't see Settings elements. That's why I made it this way. Open request in Revancify repo, so they can fix the character limit.

anddea commented 6 months ago

Check this https://github.com/anddea/revanced-patches/discussions/128#discussioncomment-8980961

aqtoo commented 6 months ago

Hopefully the above pull request gets merged and not just stuck in limbo, I appreciate your response either way and let's hope this gets fixed!