anddea / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
613 stars 43 forks source link

bug: HDR Videos disabling not working #250

Closed Anurag69 closed 6 months ago

Anurag69 commented 7 months ago

Type

Other

Tools used

RVX Manager

Application

YouTube 19.11.38

Bug description

The higher video quality not available. Even after disabling hdr I am getting hdr video quality. YouTube patched using latest anddea patches. Device is Iqoo neo 7 Pro Screenshot_20240402_160037 Screenshot_20240402_160447 Screenshot_20240402_160455

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

Iqoo Neo 7 Pro | Android 14

Acknowledgements

selfmusing commented 7 months ago

Disablw HDR Video toggle isn't working anymore on the latest versions of YouTube , I think you can use vp9 codec toggle to get rid of this HDR .

Anurag69 commented 7 months ago

I am using recommended version - 19.11.38, Is this version also not supported for disabling HDR. Is there any other YouTube version that supports disabling hdr. Or any other method to fix this because in HDR my videos starts dropping frames in even 1080p. While in previous dev patch it was working without the need of enabling vp9 codex

selfmusing commented 7 months ago

I am using recommended version - 19.11.38, Is this version also not supported for disabling HDR. Is there any other YouTube version that supports disabling hdr. Or any other method to fix this because in HDR my videos starts dropping frames in even 1080p. While in previous dev patch it was working without the need of enabling vp9 codex

USE ANY VERSION LOWER THAN 19.09.XX

[ Check This : ReVanced/revanced-patches/pull/2863 ]

Anurag69 commented 7 months ago

Thanks for the info. I will try the 19.09.xx. But I don't know what went wrong previously I was using YT 19.11.38 using anddea v223 dev 14 patch and it was working perfectly fine

anddea commented 7 months ago

HDR autobrightness is a different patch. Either patch wasn't applied, or maybe there are new server-side features by google.

Anurag69 commented 7 months ago

Hi @anddea, as I checked the patch was applied successfully and i tried the previous V223dec14 patched YT app it's also giving the same issue HDR is always showing even if the HDR is disabled. Maybe it's some server side changes. Can you try from your end , to reproduce - Disable the HDR option then open the Costa Rica video shown in screenshot and let me know if it's same for you as well?

anddea commented 7 months ago

I cannot reproduce this issue. If anyone else can reproduce it, let us know.

Maybe try to clean install, especially if it worked for you before. Is there anything that you changed so this happened? Maybe you changed sources back and forth and then it started? Or anything else?

Anurag69 commented 7 months ago

Tried clean install, nothing changed in selected patches

Anurag69 commented 7 months ago

As i checked now the HDR option is only showing for Costa Rica video shown in screenshot. Maybe this is video / user specific bug.

anddea commented 7 months ago

Can you disable Disable HDR video to check id other videos really have HDR.

I don't have HDR for Costa Rica video.

Close the issue, if disable HDR works for you.

Anurag69 commented 7 months ago

Tried disabling the HDR , as you can see the other videos does have HDR Screenshot_20240403_031622 Screenshot_20240403_031533 Screenshot_20240403_031512 Screenshot_20240403_031456

Anurag69 commented 7 months ago

After enabling the disable HDR only the costa Rica video shows the HDR option as u can see in SS Screenshot_20240403_031836 Screenshot_20240403_031823 Screenshot_20240403_031813 Screenshot_20240403_031802

Anurag69 commented 7 months ago

267 Maybe it's related to this issue

Anurag69 commented 6 months ago

Closing as it got fixed automatically by maybe some server side changes on YouTube app