search

anddea / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
566 stars 41 forks source link

feat: (YT) Remove YouTube Stock Settings #34

Closed Francesco146 closed 5 months ago

Francesco146 commented 6 months ago

Application

YouTube

Feature description

Remove this stock settings from the settings page (can't do that by a toggle, i get it. but a patch during compile time as I do that with ApkTool):

Screenshot_20240312_192850_ReVanced Extended Screenshot_20240312_192853_ReVanced Extended

Motivation

Provides cleaner look to YouTube. Debloat the settings page.

Might work good along side to #28. also, might be a reasonable alternative to the extremist #22 .

Acknowledgements

MondayNitro commented 6 months ago

which xml do you edit with apktoolm to remove those settings?

Francesco146 commented 6 months ago

which xml do you edit with apktoolm to remove those settings?

I don't remember right now, should be in resources/[lang]-values. you could grep the text you are looking for, and get the file name that way

Aryan-Chauhan commented 6 months ago

Bro, meaning of " extremist #22 " ?

Francesco146 commented 6 months ago

Bro, meaning of " extremist #22 " ?

don't take this as an offence, but that issue is trying to get right of all settings, that contains pretty useful tabs, not considering that even ReVanced's settings their self need those to work (e.g. the autoplay one). ReVanced is not handling all of these settings, for example:

And it's good as it is, removing them is quite 'extremist', and would remove functionality to the final product. something in between would be preferable in my opinion

selfmusing commented 6 months ago

💀 That day isn't far when you guys will ask for a patch to remove YouTube from YouTube app 😭

Francesco146 commented 6 months ago

💀 That day isn't far when you guys will ask for a patch to remove YouTube from YouTube app 😭

the ghostly [null] App :)

Aryan-Chauhan commented 6 months ago

Bro, meaning of " extremist #22 " ?

don't take this as an offence, but that issue is trying to get right of all settings, that contains pretty useful tabs, not considering that even ReVanced's settings their self need those to work (e.g. the autoplay one). ReVanced is not handling all of these settings, for example:

  • General
  • Background
  • Notifications
  • ...

And it's good as it is, removing them is quite 'extremist', and would remove functionality to the final product. something in between would be preferable in my opinion

Actually, I didn't ask for hiding all settings.

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

Francesco146 commented 6 months ago

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

my bad, that's not what I understood from your issue. just straight up think about how this patch could possibly be implemented. Then if that's what you meant, I'm agreeing with you.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

I'm fairly sure the goal you want to achieve is not possible with a Runtime patch, it should work with a compile time patch with some options in the json format.

Aryan-Chauhan commented 6 months ago

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

my bad, that's not what I understood from your issue. just straight up think about how this patch can possibly be implemented. Then if that's what you meant, I'm agreeing with you.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

I'm fairly sure the goal you want to achieve is not possible with a Runtime patch, it should work with a compile time patch with some options in the json format.

Yeah! Good point in your last line!

I have minimal coding knowledge, but even I guessed that it's not possible by some run-time modification (compile-time modification necessary).

anddea commented 5 months ago

Added in the latest dev.