bug(YouTube Music - Visual preferences icons): An error occurred when the Extended icon is Custom branding icon

stainlf commented 5 days ago

Type

Error while patching

Tools used

RVX Manager

Application

YouTube Music v7.06.53-

Bug description

Visual preferences icons were finally added to YouTube Music in v2.226.0-dev.3, but A patch error that occurred on YouTube in v2.224.0-dev.7 when app icon is original has recurred so far.

Error logs

- Device Info
ReVanced Manager: 1.20.4
Model: SM-S928N
Android version: 14
Supported architectures: arm64-v8a
Root permissions: No

- Patch Info
App: com.google.android.apps.youtube.music v7.06.53 (Suggested: 7.06.53)
Patches version: v2.226.0-dev.17
Patches added: Default
Patches removed: Custom package name, Amoled, Restore old style library shelf, Enable debug logging, Translations
Default patch options changed: Settings for YouTube Music [RVX settings menu name: RVX Settings], Visual preferences icons [Extended icon: custom_branding_icon]

- Settings
Allow changing patch selection: true
Version compatibility check: false
Show universal patches: false
Remove unused library: true
Use pre-release: true
Patches source: anddea/revanced-patches
Integration source: anddea/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 26 patches
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~DOZGIsa51AWV9PqxZi7ghA==/app.rvx.manager.flutter-xmDoTpBEpyoRNeeouqhQzw==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.rvx.manager.flutter/cache/patcher/tmp-YULZCQ/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.rvx.manager.flutter/cache/patcher/tmp-YULZCQ/revanced-temporary-files/apk/build/resources.zip]
    at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:144)
    at brut.androlib.AaptInvoker.invokeAapt(Unknown Source:104)
    at app.revanced.patcher.data.ResourceContext.get(SourceFile:0)
    at app.revanced.patcher.Patcher.get(SourceFile:0)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$35(Unknown Source:484)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$0x5RQW3TgU-norbj4KLWHG0V2oA(SourceFile:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda4.run(SourceFile:0)
    at java.lang.Thread.run(Thread.java:1012)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~DOZGIsa51AWV9PqxZi7ghA==/app.rvx.manager.flutter-xmDoTpBEpyoRNeeouqhQzw==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.rvx.manager.flutter/cache/patcher/tmp-YULZCQ/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.rvx.manager.flutter/cache/patcher/tmp-YULZCQ/revanced-temporary-files/apk/build/resources.zip]
    at brut.util.OS.exec(Unknown Source:75)
    at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:122)
    ... 7 more

Solution

It seems that the bug fix patch of v2.224.0-dev.8 should also be applied to YouTube Music. Thank you.

Additional context

No response

Device Environment

Android 14

Acknowledgements

[x] This issue does not reproduce on unpatched YouTube or YT Music.
[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] I have written the title and contents in English.

Francesco146 commented 5 days ago

have you tried with other patching tools?

AbakNacchan commented 5 days ago

have you tried with other patching tools?

Got similar error on CLI too. Not present on latest inotia00 sources.

stainlf commented 5 days ago

Visual preferences icons patch have not yet been merged into YouTube Music in Inotia00 patch.

Francesco146 commented 5 days ago

i see, some cherry picking went wrong

AbakNacchan commented 5 days ago

i see, some cherry picking went wrong

I guess it's a RVXSettingsMenuName problem.

stainlf commented 5 days ago

nooo maybe this

▶ Currently applied (v2.224.0-dev.7) https://github.com/anddea/revanced-patches/commit/c47dc23e5dbc06534cfdc568d2edd23b62d3f7a6 At this patch there was the same error on YouTube.

▶ Not yet applied (v2.224.0-dev.8) https://github.com/anddea/revanced-patches/commit/a4b846684bc8b0c1f3746f8cf34e7112a3c4e212 This patch doesn't seem to have been applied to YouTube Music yet.

AbakNacchan commented 5 days ago

nooo maybe this

▶ Currently applied (v2.224.0-dev.7) c47dc23 At this patch there was the same error on YouTube.

▶ Not yet applied (v2.224.0-dev.8) a4b8466 This patch doesn't seem to have been applied to YouTube Music yet.

Visual Preferences Icon has no problem with that, but if you try to change RVX Settings name, the problem will occurs. It can be solved without adding custom settings name for a while - until there's a fix - both in YouTube and YouTube Music.

stainlf commented 5 days ago

I've said it many times, but this error has been occurring since v2.226.0-dev.3. The error logs maybe have only changed as above because of the new error you mentioned, but this error is not related to the error you mentioned.

https://github.com/anddea/revanced-patches/releases/tag/v2.224.0-dev.7 As in this patch, when the value of the Visual preferences icons patch is set to Custom Branding icon while the Custom Branding icon patch is excluded, the error I mentioned occurs regardless of RVX Settings name.

stainlf commented 5 days ago

It wasn't the same bug as before, thank you.

anddea / revanced-patches