#161966897 CRUD tests for article

andela / ah-infinity-stones

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

#161966897 CRUD tests for article #18

Closed kamyaD closed 5 years ago

kamyaD commented 5 years ago

What does this PR do?

This PR contains failing CRUD tests for articles

Description of Task to be completed?

add a test for creating an article
add a test for retrieving an article
add test for editing an article
add a test for deleting an article

How should this be manually tested?

Clone the repo and cd into the project folder
Create a virtual environment by running $ python3 -m venv <name_of_environment>
Activate the virtual environment by running source <name_of_environment>/bin/activate
Run $ pip install -r requirements.txt
run python manage.py test

What are the relevant pivotal tracker stories?

#161966897

Screenshots (if appropriate)

codeplus254 commented 5 years ago

Great work! Remember to squash the commits after you finish cooking :-P so that the review process is easy.

PromasterGuru commented 5 years ago

@kamyaD resolve the conflicts as you work on the other feedbacks.

kamyaD commented 5 years ago

@r-wambui I have just pushed my latest changes which has all the feedbacks that you mentioned. Please have a look and let me know. Thanks

kamyaD commented 5 years ago

@PromasterGuru I have resolved the conflicts as you mentioned. Thanks for the ask feedback

r-wambui commented 5 years ago

@kamyaD Please rebase develop. I merged your other PR. Also resolve the merge conflicts

leonardnjura commented 5 years ago

Good work @kamyaD , Though, let's strive for utter dryness so code climate won't sense so much global warming and complain that our Infinite selves are becoming an endangered species

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit e218f60e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	4

View more on Code Climate.

kamyaD commented 5 years ago

@r-wambui @andela-amutava I have worked on the feedbacks and rebased tests @PromasterGuru branches to have his tests too so that they could be reflected in this PR.