161966913 user reset password via mail

andela / ah-infinity-stones

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

161966913 user reset password via mail #37

Closed kamyaD closed 5 years ago

kamyaD commented 5 years ago

What does this PR do? This PR allows the user to receive password reset notification on his e-mail and a link to reset the password.

Description of Task to be completed?

send a link to the user . for resetting password
reset the password through the link sent to the user

How should this be manually tested? Clone the repo and cd into the project folder Create a virtual environment by running $ python3 -m venv Activate the virtual environment by running source /bin/activate Run $ pip install -r requirements.txt run python manage.py runserver

What are the relevant pivotal tracker stories? [#161966922]

**Screenshots:*** Passing tests:

Password Reset email notification:

leonardnjura commented 5 years ago

@kamyaD this PR is awesome. We badly needed this feature because who are we to deny this experience to our users? Everyone has a lot on their plate and often times we forget passwords. Code climate, however, sniffed one or two things.

r-wambui commented 5 years ago

@kamyaD Please rebase develop and also work on merge conflicts

kamyaD commented 5 years ago

@kamyaD Please rebase develop and also work on merge conflicts

@r-wambui I managed to rebase develop and fixed the merge conflicts.

kamyaD commented 5 years ago

@kamyaD this PR is awesome. We badly needed this feature because who are we to deny this experience to our users? Everyone has a lot on their plate and often times we forget passwords. Code climate, however, sniffed one or two things.

@leonardnjura Hi Leo, I managed to have a look at code climate issues and I think they are fixed now.

r-wambui commented 5 years ago

Ensure the travis build runs.

kamyaD commented 5 years ago

Ensure the travis build runs.

@r-wambui Hello Rose, I have worked on errors in Travis and now it runs, However, there are some failing tests whose features have not been worked on. I think that is why it's showing, "Some checks were not successful". What can we do about this?

Please let me know if I did it as you expected.

r-wambui commented 5 years ago

@kamyaD Check that the tests passing in develop are also passing on this branch.

ThaDeveloper commented 5 years ago

It would be convenient to include the endpoint(s) for testing and documenting this PR's feature.

kamyaD commented 5 years ago

@kamyaD Please rebase develop and also work on merge conflicts

I have done this

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit b13323d2 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2

View more on Code Climate.