#161966915 User Profiles and Update

leonardnjura commented 5 years ago

What does this PR do?

Allows users to create their profile

Description of Task to be completed?

User logins User creates or updates their profile Time stamp is attached upon every profile edit

How should this be manually tested?

$ git clone -b ft-user-profiles-161966915 https://github.com/andela/ah-infinity-stones then $ cd ah-infinity-stones

Create and activate virtual env virtualenv -p python3 venv $ source venv/bin/activate $ pip3 install -r requirements.txt to install the dependencies Setup environment variables. Copy all from below and paste them into the .env file. Update the values to your choice: Register user via $ python3 manage.py createsuperuser --username john --email john.doe@example.com

GET http://127.0.0.1:8000/api/profiles/ GET http://127.0.0.1:8000/api/profiles/?page=2 GET http://127.0.0.1:8000/api/profiles/u GET PUT http://127.0.0.1:8000/api/profiles/<username>

export DATABASE_USER='user'
export DATABASE_PASSWORD='xxx'
export HOST='localhost'
export PORT='5432'
export DATABASE_TEST='ah_test'

 export EMAIL_HOST_USER='sendgrid_username'
 export EMAIL_HOST_PASSWORD='sendgrid_pswd'

Activate the env variables by $source .env Run migrations: $ python3 manage.py migrate Run generic tests - $ python3 manage.py test Run specific tests python3 manage.py test authors/apps/profiles

What are the relevant pivotal tracker stories?

#161966915

Screenshots

rkemmy commented 5 years ago

@leonardnjura the 'description of the task to be completed', 'what the PR does' and 'how to manually test this' are totally different and do not correlate to each other.

rkemmy commented 5 years ago

@leonardnjura please check email_confirm.html line 19 and make the necessary adjustments

leonardnjura commented 5 years ago

@leonardnjura the 'description of the task to be completed', 'what the PR does' and 'how to manually test this' are totally different and do not correlate to each other.

r-wambui commented 5 years ago

@leonardnjura please work on the merge conflicts also rebase develop to pick the current changes.

PromasterGuru commented 5 years ago

Great work, work on the merge conflicts and rebase develope to ensure you have the latest changes.

r-wambui commented 5 years ago

Resolve some of the tests, they are failing on travis but are passing develop travis build.

leonardnjura commented 5 years ago

@r-wambui note I fixed the code climate issues and cleaned up codebase as requested. Build passes locally. I also added a followers field as needed by @codeplus254. Feel free to go through once more before merge

leonardnjura commented 5 years ago

@r-wambui kindly check the changes requested on this PR

ThaDeveloper commented 5 years ago

To get or update a specific profile, is it /profiles/u or profiles/<username>? You could consider describing what the endpoints listed do.

r-wambui commented 5 years ago

@leonardnjura Please ensure that travis can complete the build to show the tests passing on this branch

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 45879f9d and detected 0 issues on this pull request.

View more on Code Climate.

andela / ah-infinity-stones