Closed andela-oogunjimi closed 8 years ago
I push to that branch right now with rewritten commit messages.
On Mon, Nov 23, 2015 at 11:33 AM, Prosper Otemuyiwa < notifications@github.com> wrote:
Re-write your commit messages with the story id and fix all the nitpick-ci issues
— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-158899812.
Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/
I said you should rewrite the commit messages with story id..yet your new commits are totally void of story id. Please fix and rebase!
The Mail issue has still not been taken care of...and I still see Redirect
facade been used in some places
Which mail issue? If it is about using the Mail facade. You said in your mail earlier that I should ignore implementing the Mail facade.
On Mon, Nov 23, 2015 at 6:26 PM, Prosper Otemuyiwa <notifications@github.com
wrote:
The Mail issue has still not been taken care of...and I still see Redirect facade been used in some places
— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-159002946.
Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/
I said ignore the nitpick CI and i commented directly under the nitpick CI comments, not the Mail Facade.
Okay. I'll work on these.
On Mon, Nov 23, 2015 at 6:48 PM, Prosper Otemuyiwa <notifications@github.com
wrote:
I said ignore the nitpick CI not the Mail Facade
— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-159009407.
Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/
Re-write your commit messages with the story id and fix all the
nitpick-ci
issues