andela / pibbble

Dribbble Clone for Programmers
https://pibbble-staging.herokuapp.com/
13 stars 3 forks source link

[Pibbble][#108215678][Write tests for authentication] #141

Closed andela-oogunjimi closed 8 years ago

unicodeveloper commented 8 years ago

Re-write your commit messages with the story id and fix all the nitpick-ci issues

andela-oogunjimi commented 8 years ago

I push to that branch right now with rewritten commit messages.

On Mon, Nov 23, 2015 at 11:33 AM, Prosper Otemuyiwa < notifications@github.com> wrote:

Re-write your commit messages with the story id and fix all the nitpick-ci issues

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-158899812.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 8 years ago

I said you should rewrite the commit messages with story id..yet your new commits are totally void of story id. Please fix and rebase!

unicodeveloper commented 8 years ago

The Mail issue has still not been taken care of...and I still see Redirect facade been used in some places

andela-oogunjimi commented 8 years ago

Which mail issue? If it is about using the Mail facade. You said in your mail earlier that I should ignore implementing the Mail facade.

On Mon, Nov 23, 2015 at 6:26 PM, Prosper Otemuyiwa <notifications@github.com

wrote:

The Mail issue has still not been taken care of...and I still see Redirect facade been used in some places

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-159002946.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 8 years ago

I said ignore the nitpick CI and i commented directly under the nitpick CI comments, not the Mail Facade.

andela-oogunjimi commented 8 years ago

Okay. I'll work on these.

On Mon, Nov 23, 2015 at 6:48 PM, Prosper Otemuyiwa <notifications@github.com

wrote:

I said ignore the nitpick CI not the Mail Facade

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/pull/141#issuecomment-159009407.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/