The github, facebook and linkedIn links don't redirect to anywhere even when I have values updated for those fields in the my profile settings

andela / pibbble

Dribbble Clone for Programmers

https://pibbble-staging.herokuapp.com/

13 stars 3 forks source link

The github, facebook and linkedIn links don't redirect to anywhere even when I have values updated for those fields in the my profile settings #259

Closed unicodeveloper closed 8 years ago

unicodeveloper commented 8 years ago

All the links should also open on a new tab when clicked.

gngchrs commented 8 years ago

@unicodeveloper I think I've only enabled the Urls, I'm wondering if the links should not appear at all in the dashboard if a user has not set them?

unicodeveloper commented 8 years ago

@andela-cganga that makes sense. Let's do it that way, the links and social media icons should not appear if a user has not set them in the profile settings.

Please, send a new PR for that

gngchrs commented 8 years ago

Ok. @unicodeveloper so I won't mark it on Pivotal as finished yet

unicodeveloper commented 8 years ago

@andela-cganga Please I need the links to be opened up on another tab when clicked

gngchrs commented 8 years ago

@unicodeveloper ok. Working on it