search

andela / pibbble

Dribbble Clone for Programmers
https://pibbble-staging.herokuapp.com/
13 stars 3 forks source link

[Feature #114298229] Show notification on meetup creation #333

Closed andela-aonyango closed 8 years ago

andela-aonyango commented 8 years ago

Added a notification to indicate that the meetup creation was successful.

Like Dribbble, the meetup controller redirects the user to the FAQ page on success, and there's a notification letting them know that their actions were successful and that they will be contacted on approval.

Refactored the mail-sending portion of the meetup controller to make it clearer, as well as to separate the addressees clearly into the user creating the email and the admins who are CCed on every meetup creation.

unicodeveloper commented 8 years ago

When I try to create a new meetup, I get this error: @andela-aonyango

screen shot 2016-02-25 at 6 02 29 pm
unicodeveloper commented 8 years ago

This is still not working @andela-aonyango . Why?

screen shot 2016-02-29 at 2 56 33 pm
andela-aonyango commented 8 years ago

@unicodeveloper, the issue, as I mentioned in a previous exchange, was that the environment variables (ADMIN_EMAILS) were not (automatically) set in the PR build. I've manually set them now but I don't know if the other PR builds will pick them up. The staging build has no issue.

So, it will work in this build but I don't know how subsequent builds will work.