search

andela / pibbble

Dribbble Clone for Programmers
https://pibbble-staging.herokuapp.com/
13 stars 3 forks source link

Social Media authentication using Github or Twitter options #74

Closed unicodeveloper closed 8 years ago

unicodeveloper commented 9 years ago

Please remove LinkedIn. We really don't need programmers logging in through linkedIn. Github and Twitter is good.

unicodeveloper commented 9 years ago

@andela-oogunjimi this feature doesn't work yet. What's the issue?

When I try to login via github, this is what I encounter

screen shot 2015-11-08 at 6 51 29 am

When i try to login via twitter, this is what I encounter

screen shot 2015-11-08 at 6 57 39 am
andela-oogunjimi commented 9 years ago

It works on my local machine. The branch is avaliable on Github; feature/social-auth. I believe we have to create another application with github and twitter. Our applications recognize pibbble as http://pibbble.app. I'll create applications for https://pibbble-staging.herokuapp.com and also include some environment variables on heroku. I'll get back to you on these.

Yours sincerely, Opeyemi Ogunjimi. Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 9 years ago

Sure, but the users wouldn't use the app on your local machine, would they?

Have you set the needed environment variables on heroku?...and what do you mean create another application with github and twitter?

Our applications recognize pibble as http://pibbble.app . This is very vague, what applications?

unicodeveloper commented 9 years ago

I need feedback on this every 30 minutes from now

andela-oogunjimi commented 9 years ago

Okay.

On Mon, Nov 9, 2015 at 12:23 PM, Prosper Otemuyiwa <notifications@github.com

wrote:

I need feedback on this every 30 minutes from now

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/issues/74#issuecomment-155032413.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

andela-oogunjimi commented 9 years ago

No, users would not use the app on my local machine. I have set environment variables for GitHub OAuth. I mean register or create the application on github and twitter. A new one different from the application used for development.

Yours sincerely, Opeyemi Ogunjimi. Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 9 years ago

Yeah, you should have done that already.

andela-oogunjimi commented 9 years ago

Prosper,

I have set the environment variables for Twitter OAuth.

Kind regards, Opeyemi Ogunjimi. Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

On Mon, Nov 9, 2015 at 1:09 PM, Prosper Otemuyiwa notifications@github.com wrote:

Yeah, you should have done that already.

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/issues/74#issuecomment-155047355.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 9 years ago

What about Github?

andela-oogunjimi commented 9 years ago

I have done that earlier.

On Mon, Nov 9, 2015 at 1:24 PM, Prosper Otemuyiwa notifications@github.com wrote:

What about Github?

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/issues/74#issuecomment-155050350.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 9 years ago

So can a user log in successfully with github and twitter now?

andela-oogunjimi commented 9 years ago

No. We have to make some changes to the users table.

On Mon, Nov 9, 2015 at 2:18 PM, Prosper Otemuyiwa notifications@github.com wrote:

So can a user log in successfully with github and twitter?

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/issues/74#issuecomment-155058892.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/

unicodeveloper commented 9 years ago

Make the changes and send in a PR to that effect, the other team members know about this change too?

andela-oogunjimi commented 9 years ago

You have merged my PR.

On Mon, Nov 9, 2015 at 3:53 PM, Prosper Otemuyiwa notifications@github.com wrote:

Make the changes and send in a PR to that effect, the other team members know about this change too?

— Reply to this email directly or view it on GitHub https://github.com/andela/pibbble/issues/74#issuecomment-155085002.

Opeyemi Ogunjimi | Software Developer | Andela (c) +234-703-936-2475 | Andela.com http://andela.com/