andelf / go-curl

golang curl(libcurl) binding.
Apache License 2.0
485 stars 131 forks source link

add TLS1.3 support #74

Closed jhfeng closed 4 years ago

jhfeng commented 4 years ago

Adding TLS1.3 option in go-curl

jhfeng commented 4 years ago

@andelf are you the current maintainer for go-curl ? Please review this simple PR.

andelf commented 4 years ago

Thanks. :)

andelf commented 4 years ago

It's not as that simple. backward compatibility should be maintained.

andelf commented 4 years ago

It's been a long time(years) since I last edited these codes(actually wrote code in golang). I will deal with the feature requests / PRs this weekend.

It might be solved by compatgen.py & compat.h.

andelf commented 4 years ago

This repo seems to support from curl 7.10.1, which is very old.

jhfeng commented 4 years ago

@andelf do you plan to actively maintain this repo ? I'm looking at it if I can use it in our service, but we need it to support new version of curl.

andelf commented 4 years ago

I haven't written any golang code for years. :) The maintain status might be terrible now. To actively maintain the repo, first, I need to look into the historical code generating tools.

I will resolve your issue this weekend.

The latest libcurl version update in this repo is 7.51.0, in 2016. The latest libcurl version is 7.71.0.