search

andelf / s3-presign

A minimal library for generating presigned URLs for Amazon S3 compatible services
Apache License 2.0
6 stars 1 forks source link

Use selected features only from chrono #1

Open mvalkanov opened 1 month ago

mvalkanov commented 1 month ago

If the dependency on chrono excludes the default features, consumers of s3-presign will see much less transitive dependencies in their Cargo.lock file (no need to have android-tzdata, android_system_properties, wasm-bindgen, wasm-bindgen-backend, windows-core, iana-time-zone, bumpalo there).

My suggestion is to change in Cargo.toml: chrono = "0.4" to chrono = { version = "0.4", default-features = false, features = ["std", "now"] }

andelf commented 1 month ago

Thanks. It's better to make it an optional feature.

s3-presign was originally made work under WASM. So chrono with no-default-feature is introduced.