search

anderly / SimpleMembership.Mvc3.Sample

3 stars 3 forks source link

Update for sample to include changing password, resetting, forgetting password as well as email validation. #1

Closed klabranche closed 13 years ago

klabranche commented 13 years ago

I added these controller actions and views because of a project I am working on atm. Let me know if I can do anything else to assist.

Thanks, Kevin LaBranche

anderly commented 13 years ago

Hi Kevin,

Thanks for submitting this.

Here's what I'm thinkining...

Initially, I wanted this SimpleMembership.Mvc3.Sample to provide the bare bones example of how to use the SimpleMembership.Mvc3 package by providing a pre-wired AccountController.

However, as you and others have pointed out, there are still a lot of folks wanting a full-fledged sample project. I blogged about that here: http://anderly.com/2011/08/11/using-simplemembership-in-mvc3/ , but I haven't made the code sample from that post a NuGet package.

My only hesitation in incorporating all of your changes is that, initially, I didn't want to step on anyone's existing Models and Views that they may have in their project if they are just trying to add SimpleMembership to an existing project.

So, I'm thinking that maybe I need to create a third NuGet package or just a VS project template for an MVC 3 project pre-wired to use SimpleMembership vs. the default membership provider.

Curious to get your thoughts?

Did you have an existing project you were adding SimpleMembership to or were you starting from scratch? I definitely want to support both scenarios, but want to make sure I do it the right way.

Let me know.

Adam

klabranche commented 13 years ago

I agree with not running over someone else's work. Wouldn't be too hot! I was starting from scratch but I definitely see both scenarios. I think a new NuGet package would be great. A template while also great for me is becoming less important as I have been using NuGet more and more but I do think if I was using it all the time I would use a template. I would start with a package and do the template after if we thought it would be used. :-) Thanks, Kevin

Date: Wed, 14 Sep 2011 07:51:28 -0700 From: reply@reply.github.com To: klabran@hotmail.com Subject: Re: [SimpleMembership.Mvc3.Sample] Update for sample to include changing password, resetting, forgetting password as well as email validation. (#1)

Hi Kevin,

Thanks for submitting this.

Here's what I'm thinkining...

Initially, I wanted this SimpleMembership.Mvc3.Sample to provide the bare bones example of how to use the SimpleMembership.Mvc3 package by providing a pre-wired AccountController.

However, as you and others have pointed out, there are still a lot of folks wanting a full-fledged sample project. I blogged about that here: http://anderly.com/2011/08/11/using-simplemembership-in-mvc3/ , but I haven't made the code sample from that post a NuGet package.

My only hesitation in incorporating all of your changes is that, initially, I didn't want to step on anyone's existing Models and Views that they may have in their project if they are just trying to add SimpleMembership to an existing project.

So, I'm thinking that maybe I need to create a third NuGet package or just a VS project template for an MVC 3 project pre-wired to use SimpleMembership vs. the default membership provider.

Curious to get your thoughts?

Did you have an existing project you were adding SimpleMembership to or were you starting from scratch? I definitely want to support both scenarios, but want to make sure I do it the right way.

Let me know.

Adam

Reply to this email directly or view it on GitHub: https://github.com/anderly/SimpleMembership.Mvc3.Sample/pull/1#issuecomment-2093901

anderly commented 13 years ago

Ok, thanks for the feedback.

I'm thinking your changes would be ideal for either a new MVC3 project or Empty MVC3 project, so maybe I incorporate them into the new package.

Or, I could probably make the existing package smart enough (with PowerShell) to detect if the AccountModels and Views exist and only add them if they don't already exist.

I'll play with it a little bit and let you know what I'm thinking.

klabranche commented 13 years ago

Awesome! If I can help anymore let me know. :-)

Date: Wed, 14 Sep 2011 08:48:03 -0700 From: reply@reply.github.com To: klabran@hotmail.com Subject: Re: [SimpleMembership.Mvc3.Sample] Update for sample to include changing password, resetting, forgetting password as well as email validation. (#1)

Ok, thanks for the feedback.

I'm thinking your changes would be ideal for either a new MVC3 project or Empty MVC3 project, so maybe I incorporate them into the new package.

Or, I could probably make the existing package smart enough (with PowerShell) to detect if the AccountModels and Views exist and only add them if they don't already exist.

I'll play with it a little bit and let you know what I'm thinking.

Reply to this email directly or view it on GitHub: https://github.com/anderly/SimpleMembership.Mvc3.Sample/pull/1#issuecomment-2094549

anderly commented 13 years ago

Kevin,

SimpleMembership.Mvc3.Sample 1.2 has been published to NuGet.

I went ahead and added the account confirmation, forgot password, password reset, functionality. I moved the emailing into a service in the Services folder which should allow for better testing scenarios.

Same instructions apply as before. You need to remove the default AccountController and rename the SimpleMembershipAccountController.cs to AccountController.cs.

Let me know what you think.

Adam

klabranche commented 13 years ago

Awesome! Thanks.

Date: Wed, 19 Oct 2011 09:38:19 -0700 From: reply@reply.github.com To: klabran@hotmail.com Subject: Re: [SimpleMembership.Mvc3.Sample] Update for sample to include changing password, resetting, forgetting password as well as email validation. (#1)

Kevin,

SimpleMembership.Mvc3.Sample 1.2 has been published to NuGet.

I went ahead and added the account confirmation, forgot password, password reset, functionality. I moved the emailing into a service in the Services folder which should allow for better testing scenarios.

Same instructions apply as before. You need to remove the default AccountController and rename the SimpleMembershipAccountController.cs to AccountController.cs.

Let me know what you think.

Adam

Reply to this email directly or view it on GitHub: https://github.com/anderly/SimpleMembership.Mvc3.Sample/pull/1#issuecomment-2458101