search

andersao / l5-repository

Laravel 5 - Repositories to abstract the database layer
http://andersao.github.io/l5-repository
MIT License
4.19k stars 876 forks source link

Incompability with PHP 7.4 - implode parameters order mix #679

Open rafaelneris opened 4 years ago

rafaelneris commented 4 years ago

Incompability using Laravel 6 and PHP 7.4

When I trying create a Presenter, I'm getting following error. RFC: https://wiki.php.net/rfc/deprecations_php_7_4 ErrorException : implode(): Passing glue string after array is deprecated. Swap the parameters

at xxx/vendor/prettus/l5-repository/src/Prettus/Repository/Generators/Generator.php:262 258| if ($rootNamespace == false) { 259| return null; 260| } 261|

262| return 'namespace ' . rtrim($rootNamespace . '\' . implode($segments, '\'), '\') . ';'; 263| }

ayimdomnic commented 4 years ago

@rafaelneris I am also getting a similar issue when trying to create a presenter

Screen Shot 2020-01-06 at 12 36 43 PM
honarkhah commented 4 years ago

https://github.com/andersao/l5-repository/pull/688