Trait `CacheableRepository` - `getCacheMinutes` method was removed without breaking version?

andersao / l5-repository

Laravel 5 - Repositories to abstract the database layer

http://andersao.github.io/l5-repository

MIT License

4.19k stars 878 forks source link

Trait `CacheableRepository` - `getCacheMinutes` method was removed without breaking version? #763

Open coelsman opened 3 years ago

coelsman commented 3 years ago

From version 2.7.7 to 2.7.9, method getCacheMinutes had been replaced by getCacheTime. As I investigated, the origin PR (#762) was marked as breaking changes, the released version must be 2.8 or whatever like that.

Follow new changes, I suggest:

Keep origin getCacheMinutes method.
Write new method called getCacheSeconds.
Method getCacheTime: handle difference of ttl between Laravel version and call correspond method above.

bsormagec commented 3 years ago

I am open to PR about this @coelsman :)