andersbandt / Financial-Analyzer

Analyzes spending, budget, and investment data in a CLI
GNU General Public License v3.0
17 stars 4 forks source link

categories/__init__.py has conflicting import * statements #4

Closed nathan-hello closed 1 year ago

nathan-hello commented 1 year ago

edit: this issue is now on the main branch

i had gotten rid of all of the import * statements, but there is one file which this isn't possible without more discretion and i don't know enough about tkinter to try to make the choice.

in src/categories/init.py, there is from tkinter import and from tkinter.ttk import . there are three Label objects that are from both of the modules in the Category class method inter_gui below. These Label objects are currently being inherited from tkinter.ttk because that is latest import in the file. so, if what's working now works, we get rid of from tkinter import *. my assumption would to be to do this.

andersbandt commented 1 year ago

sounds good. tkinter.ttk is for adding themes to stuff like the Labels. I say get rid of from tkinter import *