Bugs in cudarray/cudarray/numpy_backend/nnet/lrnorm_bc01.pyx

andersbll / cudarray

CUDA-based NumPy

MIT License

233 stars 61 forks source link

Bugs in cudarray/cudarray/numpy_backend/nnet/lrnorm_bc01.pyx #29

Open donglaiw opened 8 years ago

donglaiw commented 8 years ago

In line 47: why is it "range(N+1)"? if we pad "half" number of 0 in both ends, then it should be "range(tailLength)".

in line 79: inline function "addToNormWindow" doesn't seem to update the variable "norm_window". I verified it by printing out its value.

Thanks

Reference: decaf implementation https://github.com/UCB-ICSI-Vision-Group/decaf-release/blob/master/decaf/layers/cpp/local_response_normalization.cpp

andersbll commented 8 years ago

Thank you for going throught the code so thoroughly. It's pretty buggy and I think it's better to remove it completely. I don't have time to implement it at the moment. I'm sorry for the trouble.

Of course, a PR is always welcome! :)