search

andersblomqvist / enhanced-mob-spawners

Mod for Minecraft (Fabric). Adding new features to the Spawner
https://www.curseforge.com/minecraft/mc-mods/enhanced-mob-spawners
Creative Commons Zero v1.0 Universal
9 stars 15 forks source link

[Bug]: Config bug preventing blocks from being dropped #109

Closed Whunder888 closed 2 months ago

Whunder888 commented 2 months ago

Steps to Reproduce the Bug

Go into config and change "disable_silk_touch": 0 to 1

Enhanced Mob Spawner filename

spawnermod 1.21.1 version 1.2.7 fabric .

Other mod filename (Optional)

No response

Extra Notes (Optional)

No response

andersblomqvist commented 2 months ago

This works as expected. For clarification:

Read it as: "do we disable the ability to silk touch the spawner?" Yes=1 or No=0.

Whunder888 commented 2 months ago

Sorry I was unclear. The feature is working, but it's a bit too much: not only are spawners not dropping items, but no blocks in the world are dropping anything. It's almost as if the "doTileDrops" gamerule is set to false (I checked, and it isn't).

Whunder888 commented 2 months ago

https://github.com/user-attachments/assets/7121a761-86fe-42b9-8786-e6462093fc37

Here is a clip of what's happening

andersblomqvist commented 2 months ago

Hmm yea that’s not intended behavior. It seems related to issue #99.

andersblomqvist commented 2 months ago

I'll have to investigate

Whunder888 commented 2 months ago

Thank you ^^

I did open and close another issue, didn't know if you had notifications on. Feel free to delete It (#111 .

andersblomqvist commented 2 months ago

The fix was very simple and almost embarrassing that it managed to slip through. I've uploaded a new mod version: 1.2.8 to download on modrinth: https://modrinth.com/mod/enhanced-mob-spawners/version/1.2.8