search

andersblomqvist / enhanced-mob-spawners

Mod for Minecraft (Fabric). Adding new features to the Spawner
https://www.curseforge.com/minecraft/mc-mods/enhanced-mob-spawners
Creative Commons Zero v1.0 Universal
9 stars 14 forks source link

Modded spawners sometimes don't drop spawn eggs + redstone #55

Closed Raidobw2 closed 2 years ago

Raidobw2 commented 2 years ago

Hi!

I've played around with it a bit in 1.18.2, and it's pretty cool. I was wondering about some inconsistencies sometimes with spawn eggs from spawners. For example, normal vanilla spawners work as intended, although some modded spawners like the ones that can spawn "Bloviators" from Cloud Storage will drop an empty spawner and no spawn egg.

I think this may be due to their naming convention (spawn_egg is placed before): image

I was wondering if there is something you could do for those cases. Or else, would it be possible to code the spawners to drop with their configuration as an item (not dropping any spawn eggs)? Possibly this could also be a toggled feature in the configuration file, just an idea.

As well I've noticed a quirk with redstone, it looks like this does not work (the spawner does not turn off): image Any directly adjacent redstone does work though. Perhaps this is linked to an old issue, #32?

Thanks in advance!

-Versions- Minecraft 1.18.2 Forge 40.1.20 Enhanced Mob Spawners spawnermod-1.18.2-1.8.15+Forge.jar Cloud Storage cloudstorage-1.1.0-1.18.2.jar

Saereth commented 2 years ago

I will say looking at the source here the naming convention spawn_egg_bloviator deviates from the mojang standard of mob_spawn_egg. All modded entites with that naming convention work so perhaps just checking the string for spawn_egg would be enough or letting us add custom additions in a config would solve it as well.

As far as the redstone issue, in https://github.com/andersblomqvist/enhanced-mob-spawners/blob/master/src/main/java/com/branders/spawnermod/event/EventHandler.java#L180-L181

using world.hasNeighborSignal(spawnerPos); might work better.

Great mod btw, very useful 👍

andersblomqvist commented 2 years ago

Thanks for the detailed issue.

As @Saereth said, the bloviator does deviate in its naming. I will stick to Mojang standards. A new config field could solve the issue, however I'm not sure if I'll add one. A better solution would be if Cloud Storage followed Mojang standards.

Regarding the redstone: seems like a bug which should be fixed.

andersblomqvist commented 2 years ago

This issue was fixed together with an update to Minecraft 1.19.