andersblomqvist / enhanced-mob-spawners

Mod for Minecraft (Fabric). Adding new features to the Spawner
https://www.curseforge.com/minecraft/mc-mods/enhanced-mob-spawners
Creative Commons Zero v1.0 Universal
9 stars 14 forks source link

add forge 1.19.4 compatibility #78

Closed mordof closed 1 year ago

mordof commented 1 year ago

I made this branch off commit 7cae4094972edb6cbccbe5c7b93fe795174f2fb6, but I'm not sure how to make a pull request (or if I even can) in github from a specific commit.

I chose that commit because the only thing after it on the forge branch is the 1.20.1 update. While 1.20.1 looks to have updated gradle and lots of build aspects, all of the changes needed to bump from 1.19.3 to 1.19.4 were found in the code from the 1.20.1 update.

I've tested this on single player, by toggling to creative, making a spawner and silk touch diamond pick, then going back to survival and mining the spawner. that worked correctly. Also tested by installing this mod on my multiplayer server. used the above process both without the mod (works as expected, simply destroys the spawner), then adding the mod because correctly with providing an empty spawner and the related egg.

If there's anything else I can do to help add this for others, please let me know. I've seen people on the forge mod website comments asking for this, but also noticed your note about dealing with life things these days so I'll help get this sorted as much as I can if you are interested in making this available to others.

andersblomqvist commented 1 year ago

Thanks for the commit and your support for the community.

I will not push this PR into the forge branch because this refers to an older minecraft version, current forge branch is 1.20.1 as you saw. I tested the mod myself and it works good! I will build the mod and upload a new version onto modrinth and curse.