fix GCC 10 compile issue [-Werror=mismatched-new-delete]

andersen-lab / ivar

iVar is a computational package that contains functions broadly useful for viral amplicon-based sequencing.

https://andersen-lab.github.io/ivar/html/

GNU General Public License v3.0

115 stars 39 forks source link

fix GCC 10 compile issue [-Werror=mismatched-new-delete] #135

Closed fizwit closed 2 years ago

fizwit commented 2 years ago

fix issue #134 and #108

fizwit commented 2 years ago

I can not reproduce the MacOS build error with Monterey 12.3.1

fizwit-MBP ivar % src/ivar version
iVar version 1.3.1

g++ --version
Apple clang version 13.1.6 (clang-1316.0.21.2.3)
Target: arm64-apple-darwin21.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

cmaceves commented 2 years ago

addressed in PR #136

JacobHayes commented 1 year ago

I don't think PR #136 covered this (only the call_consensus_pileup error), I'm still getting this issue as of https://github.com/andersen-lab/ivar/commit/bafc7b93b195b83caf0a8e8054f49565cb6dee79. That PR does mention delete files, but as also noted master has diverged - indeed it now uses free(files). After making the change in this PR, I was able to compile again.

Can this be re-opened and merged? Thanks! I can put together a reproducible example if needed.