search

andersen-lab / ivar

iVar is a computational package that contains functions broadly useful for viral amplicon-based sequencing.
https://andersen-lab.github.io/ivar/html/
GNU General Public License v3.0
115 stars 39 forks source link

addressing issue #132 #137

Closed cmaceves closed 1 year ago

cmaceves commented 2 years ago

addressing issue #132, allowing both forward and reverse primers to be trimmed from a strand if the primer pair file is passed using the experimental -f flag. issue raised for small insert sizes by a user.

cmaceves commented 2 years ago

for unpaired data, if a primer pair file is provided, we now use that information to determine which NT's to trim

khyox commented 2 years ago

Hi Chrissy, thank you so much for working on these important issues! Do you have an estimate of when you will be ready to merge your code changes? Are you thinking of a new version tag after this? Thank you very much!

cmaceves commented 2 years ago

Hi @khyox! We will be looking to bump versions after this merge. Review is still in progress, should be within the next few weeks

khyox commented 2 years ago

Thank you so much for your reply and for your work on the merge, Chrissy! We will be looking forward to it and the version bump.