andersen-lab / ivar

iVar is a computational package that contains functions broadly useful for viral amplicon-based sequencing.
https://andersen-lab.github.io/ivar/html/
GNU General Public License v3.0
118 stars 40 forks source link

Error building the docker image from the Dockerfile #165

Closed jonbra closed 1 year ago

jonbra commented 1 year ago

Describe the bug I ran docker build on the Dockerfile but got an error compiling iVar

Desktop (please complete the following information):

Additional context Part of my output:

#0 10.58 trim_primer_quality.cpp:595:14: error: 'header' was not declared in this scope
#0 10.58    sam_hdr_t *header = sam_hdr_read(in);
#0 10.58               ^~~~~~
#0 10.58 trim_primer_quality.cpp:595:14: note: suggested alternative: 'gz_header'
#0 10.58    sam_hdr_t *header = sam_hdr_read(in);
#0 10.58               ^~~~~~
#0 10.58               gz_header
#0 10.62 Makefile:367: recipe for target 'trim_primer_quality.o' failed
#0 10.62 make[2]: Leaving directory '/root/ivar/src'
#0 10.62 make[2]: *** [trim_primer_quality.o] Error 1
#0 10.63 Makefile:360: recipe for target 'all-recursive' failed
#0 10.63 make[1]: Leaving directory '/root/ivar'
#0 10.63 make[1]: *** [all-recursive] Error 1
#0 10.63 Makefile:301: recipe for target 'all' failed
#0 10.63 make: *** [all] Error 2
------
Dockerfile:28
--------------------
  27 |     # iVar
  28 | >>> RUN cd root/ &&\
  29 | >>>     git clone https://github.com/andersen-lab/ivar.git &&\
  30 | >>>     cd ivar/ &&\
  31 | >>>     ./autogen.sh &&\
  32 | >>>     ./configure &&\
  33 | >>>     make &&\
  34 | >>>     make install
  35 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c cd root/ &&    git clone https://github.com/andersen-lab/ivar.git &&    cd ivar/ &&    ./autogen.sh &&    ./configure &&    make &&    make install" did not complete successfully: exit code: 2
cmaceves commented 1 year ago

thank you for brining this up - I was able to replicate the error and we'll look into it!

cmaceves commented 1 year ago

hi! @jonbra would you mind pulling down this branch https://github.com/andersen-lab/ivar/tree/issue_165 and confirming that the image will build?

jonbra commented 1 year ago

Yep, it builds nicely! :)