andersennl / case-switch

Atom editor package to change variable names from kebab- to snake- to camelCase.
MIT License
4 stars 3 forks source link

Keybindings conflict with copy key #5

Closed dabou closed 8 years ago

dabou commented 8 years ago

The keybindings 'ctrl-c ctrl-c' package are in conflict with native copy keybinding 'ctrl-c'. Half the time the copy don't work. Can you enable the personalization of keybindings in the package like the capture: capture du 2016-05-26 13 29 18

Thereby the user can disable and change keybindings.

Thank's for your package.

andersennl commented 8 years ago

Hi @dabou thanks for bringing this to my attention.

I've looked into it - please correct me if I'm mistaken but I'm able to change the keybinding like this in your keymap.cson: bildschirmfoto 2016-05-26 um 17 03 45

You can additionally disable the preset keybindings: bildschirmfoto 2016-05-26 um 17 06 06

If you follow these steps, is there still a conflict? Or is the "disabling default keybindings" something you don't want to do?

andersennl commented 8 years ago

@dabou is there anything I can do for you? Otherwise I'd close the issue.

dabou commented 8 years ago

Thank's a lot ! When i add the keybinding in the user keymap file (keymap.cson), the preset keybindings appeared in the package settings and can disable. So the conflict is resolved. :v:

You can close the issue and thank you for your reactivity.

andersennl commented 8 years ago

Glad it works for you, I'll close the issue 👍

steveoh commented 8 years ago

I would suggest not using ctrl-c as a default. This breaks every windows user and is a pain to track down.

andersennl commented 8 years ago

@steveoh yes that's absolutely right. I can change it soon but feel free to create a pull request if you want to.