andersfylling / disgord

Go module for interacting with the documented Discord's bot interface; Gateway, REST requests and voice
BSD 3-Clause "New" or "Revised" License
496 stars 70 forks source link

feat: threads #439

Closed beachasaurus-rex closed 2 years ago

beachasaurus-rex commented 2 years ago

Description

Adding interfaces to allow users to deal with threads. Using this as my reference.

Breaking Change?

yes. new webhook query parameter

Benchmarks

I don't think I need benchmarks for this, but please let me know if I'm wrong

Checklist:

beachasaurus-rex commented 2 years ago

In short, a thread is type of channel, but with a few new, nullable fields.

Should I implement convenience functions for people, such as being able to specifically get only channels that are threads, or should I leave that as something for users to do themselves?

I can argue both sides of the issue myself, but I'd definitely like to hear other opinions.

Edit: irrelevant question due to https://discord.com/developers/docs/resources/guild#get-guild-channels

andersfylling commented 2 years ago

/run integration-tests

edit: only I can execute this command

github-actions[bot] commented 2 years ago

:heavy_check_mark: integration tests succeeded

andersfylling commented 2 years ago

/run integration-tests

github-actions[bot] commented 2 years ago

:heavy_check_mark: integration tests succeeded

andersfylling commented 2 years ago

/run integration-tests

github-actions[bot] commented 2 years ago

:heavy_check_mark: integration tests succeeded