andersfylling / disgord

Go module for interacting with the documented Discord's bot interface; Gateway, REST requests and voice

BSD 3-Clause "New" or "Revised" License

496 stars 70 forks source link

feat: guild-scheduled-event #470

Closed Aldiwildan77 closed 2 years ago

Aldiwildan77 commented 2 years ago

Description

Add guild scheduled event features from discord, check this out for the APIs

Issues: #467

Breaking Change?

Checklist:

[x] I have performed a self-review of my own code
[x] Commented complex situations or referenced the discord documentation
[x] Updated documentation
[x] Added Integrated Test

Aldiwildan77 commented 2 years ago

Nice PR! there's a few things, but looking great overall.

Edit: oh sorry! I got a notification and my mind figured it was ready for review, just saw the draft status. Please ignore the below ^^,

Sorry, I'm busy this week, thanks for reviewing my code and I'll change it soon.

Aldiwildan77 commented 2 years ago

Please review these updated codes @andersfylling

andersfylling commented 2 years ago

It looks good!

I don't use testify here though, and I would prefer to keep it that way. It caused some confusion in the past, and becomes a bit inconsistent with the remaining code base introducing it now.