andersfylling / disgord

Go module for interacting with the documented Discord's bot interface; Gateway, REST requests and voice
BSD 3-Clause "New" or "Revised" License
502 stars 71 forks source link

chore: Remove unused methods #516

Open jacks0n9 opened 1 year ago

jacks0n9 commented 1 year ago

Sorry anders, I forgot to pull before i started working, so there are 2 commits.

Description

Breaking Change?

no

Benchmarks

Checklist:

andersfylling commented 1 year ago

Looks like you have two pull request that does the same ish. Is there a need for me to review both?

jacks0n9 commented 1 year ago

Looks like you have two pull request that does the same ish. Is there a need for me to review both?

the other one fixes warnings that don't involve unused code, this one actually removes unused code.

andersfylling commented 1 year ago

Yes, I don't think you need 2 pull requests for this. Could you merge them into one?

jacks0n9 commented 1 year ago

Yes, I don't think you need 2 pull requests for this. Could you merge them into one?

how do i do that?

jacks0n9 commented 1 year ago

Yes, I don't think you need 2 pull requests for this. Could you merge them into one?

i closed the other pr, so just merge this one and i can add the stuff in the other pr next

andersfylling commented 1 year ago

github actions are failing btw