search

andersk / enum_primitive-rs

Macro to generate num::FromPrimitive instances for enum that works in Rust 1.0
MIT License
63 stars 22 forks source link

Community patches roll-up #13

Closed skull-squadron closed 1 year ago

skull-squadron commented 7 years ago

Boils down community improvements into a tiny mega PR.

cardoe commented 7 years ago

You will need to bump the minimum Rust version in .travis.yml to match what num_traits requires, which based on the errors appears to be 1.8.0. I think at this point its ok to do so given how old 1.0.0 and 1.8.0 are.

skull-squadron commented 7 years ago

Could you edit that? I'm far away from any laptop. On Wed, Aug 30, 2017 at 7:21 AM Doug Goldstein notifications@github.com wrote:

You will need to bump the minimum Rust version in .travis.yml to match what num_traits requires, which based on the errors appears to be 1.8.0. I think at this point its ok to do so given how old 1.0.0 and 1.8.0 are.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/andersk/enum_primitive-rs/pull/13#issuecomment-326005740, or mute the thread https://github.com/notifications/unsubscribe-auth/AANsMEhUXc_IwfcHnPSTCCQQ-t_LdjR6ks5sdW_ZgaJpZM4PBVW1 .

cardoe commented 7 years ago

I'm not the author nor do I have commit access.

skull-squadron commented 7 years ago

@cardoe Oh well, thanks for noticing it. I was in the desert, but not doing Burning Man this year though. I'll play this for myself cryin' in my beer ;) insert tiny violin

🤘

skull-squadron commented 7 years ago

Yes, it doesn't appear to add anything of value.