search

andersongraciano / google-oauth-java-client

Automatically exported from code.google.com/p/google-oauth-java-client
0 stars 0 forks source link

OAuthParameters repeated parameters problem #91

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
It seems like it fails when there is more than one parameter with the same name.

Duplicated parameter names should be taken into account when building the 
signature according to [9.1.1. Normalize Request 
Parameters](http://oauth.net/core/1.0/).

But it looks like 
[OAuthParameters](https://code.google.com/p/google-oauth-java-client/source/brow
se/google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthParam
eters.java?name=1.17.0-rc) doesn't consider these two possibilities on method 
"computeSignature()" (line 137). In fact, at line 157 we have the following 
code:

    for (Object repeatedValue : (Collection<?>) value) {
        putParameter(parameters, name, repeatedValue);
    }

which keeps only the last value for a repeated parameter.

Related StackOverflow post:
http://stackoverflow.com/questions/4921523/userservice-getcurrentuser-returns-nu
ll

Original issue reported on code.google.com by lautaro....@globant.com on 4 Apr 2014 at 4:17