search

andersonshatch / soma-ctrl

Node util for controlling SOMA smart shade via MQTT or HTTP
MIT License
21 stars 6 forks source link

Update dependencies with versions compatible with Node 10 #82

Closed ThomasPrior closed 5 years ago

ThomasPrior commented 5 years ago

bluetooth-hci-socket has been updated to @abandonware/bluetooth-hci-socket and the original project has gone stale.

noble has been updated to @abandonware/noble for the same reason.

andersonshatch commented 5 years ago

Thanks for this, it’s something I had been meaning to look at! Does this version still work with older versions of node, or would an upgrade be required as part of this change?

Before merging, I’d like to see some updates to the README as I think there are some notes in there that would no longer be valid, and the build failing is a little concerning as all it’s doing is an npm install, though that may be because that library is not compatible with older node versions?

ThomasPrior commented 5 years ago

I'll rebuild my machine tonight and test on clean Node 8 and 9 installs.

I'll take a look at the readme during the week and get back to you with any changes I'd like to make.

On Sat, 28 Sep 2019, 19:46 Josh Anderson, notifications@github.com wrote:

Thanks for this, it’s something I had been meaning to look at! Does this version still work with older versions of node, or would an upgrade be required as part of this change?

Before merging, I’d like to see some updates to the README as I think there are some notes in there that would no longer be valid, and the build failing is a little concerning as all it’s doing is an npm install, though that may be because that library is not compatible with older node versions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/andersonshatch/soma-ctrl/pull/82?email_source=notifications&email_token=AIEIC2FRR5ICFPHUXWQA27DQL6Q73A5CNFSM4I3PCEW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73AA4Q#issuecomment-536215666, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEIC2HUMY5OE7EKVTNNSTLQL6Q73ANCNFSM4I3PCEWQ .

ThomasPrior commented 5 years ago

Closing and reopening PR with changes - I oops'd a version number in package-lock.json