search

andersthemagi / magicalmusings.github.io

Website hosting my own thoughts for TTRPG gameplay / game mastering
https://magicalmusings.github.io/
MIT License
6 stars 8 forks source link

added four level 1 spells #40

Closed Isaac-Tait closed 4 years ago

Isaac-Tait commented 4 years ago

I added the following:

2020-10-13-spells-1-absorb-elements.md 2020-10-13-spells-1-acid-stream.md 2020-10-13-spells-1-arcane-weapon.md 2020-10-13-spells-1-armor-of-agathys.md

I would like to contribute more but I wanted to make sure I was completing the spells correctly.

Will you go in later and change the descriptions and other descriptors (e.g. school, casting time, duration, etc...)? Or is that something I should do? If so where can I conduct the research for the various spells?

Thank you for your time. I look forward to your response.

magicalmusings commented 4 years ago

All of the descriptors should be filled out before being merged. If you look up 'dnd spells 5e' on google, plenty of resources should pop up. One website I like is this one for the data http://dnd5e.wikidot.com/spells

Hopefully that clears up your question, let me know if there's anything else I can clarify

Isaac-Tait commented 4 years ago

That does clear up my question. Thank you. I will get to work and submit a new PR

Isaac-Tait commented 4 years ago

I added 12 level 1 spells with proper formatting and all fields updated/completed as requested.

Isaac-Tait commented 4 years ago

Requested changes have been made. Thank you for the review, some of the descriptors vary from spells list page to when you actually click on the spell name. I will keep that in mind for future work. Cheers.

magicalmusings commented 4 years ago

Fantastic, thank you so much @Isaac-Tait ! Appreciate your help with this.