search

andersundsehr / aus_driver_amazon_s3

Provides a TYPO3 FAL driver for the Amazon Web Service S3
GNU Lesser General Public License v3.0
20 stars 39 forks source link

fix file deletion and rename in root dir for 8.7.16 #37

Closed dni closed 5 years ago

dni commented 6 years ago

suggested by Nicole Cordes

ich hab gleichzeit aber auch nen core-patch, wenn du den testen magst?! kannst dir aussuchen: extension ändern, core ändern, oder beides :slightly_smiling_face: genau, in \AUS\AusDriverAmazonS3\Driver\AmazonS3Driver https://review.typo3.org/57120 release: wenn ich das richtig sehe, ist das nächste release am 21.8 geplant

Lagerregal commented 5 years ago

Code style has to be fixed (see travis):

FILE: ...rsundsehr/aus_driver_amazon_s3/Classes/Driver/AmazonS3Driver.php

FOUND 7 ERRORS AFFECTING 7 LINES

1384 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 1385 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 3 1386 | ERROR | [x] Line indented incorrectly; expected at least 8 spaces, found 7 1387 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7 1388 | ERROR | [x] Line indented incorrectly; expected at least 12 spaces, found 11 1389 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7 1390 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3

c0defre4k commented 5 years ago

Any updates on this? This issue exists since almost 3 months!

dni commented 5 years ago

i think this should be fixed with 8.7.19 was a 8.6.16 specific issue, the PR should be obsolete now, but i have not tested it in depth.

c0defre4k commented 5 years ago

I have 8.7.19 in my projects and the problem still persists. Although I don't know if there is another problem causing the same issue.

dni commented 5 years ago

ok, does my PR fix your issue? then ill try to fix the codecheck is submit it again.

c0defre4k commented 5 years ago

Just tested your fix. It worked for me. 👍

dni commented 5 years ago

ok, fixed it should be ready to merge now.