andersundsehr / aus_driver_amazon_s3

Provides a TYPO3 FAL driver for the Amazon Web Service S3
GNU Lesser General Public License v3.0
20 stars 39 forks source link

MultipartUploader fails to upload empty files #69

Closed berndbrot closed 3 years ago

berndbrot commented 4 years ago

Empty files cannot be created with MultpartUploader. Also, when an error occurs in the MultipartUploader, the MultipartUploadAdapter will retry the upload forever. This might be useful for temporary errors like Network problems, but blocks a PHP process and creates high server load for permanent errors (like the one with the empty files)

This patch

I'm not sure if MAX_RETRIES = 10 is appropriate, but in my tests I didn't need a single retry even when uploading big files.