search

andersundsehr / aus_driver_amazon_s3

Provides a TYPO3 FAL driver for the Amazon Web Service S3
GNU Lesser General Public License v3.0
21 stars 40 forks source link

[BUGFIX] Throw \InvalidArgumentException when a file does not exist. #80

Closed cweiske closed 1 year ago

cweiske commented 3 years ago

.. instead of throwing a generic \Exception.

\TYPO3\CMS\Core\Resource\Driver\LocalDriver (TYPO3 v10.4) already throws that exception class when a file does not exist. Other extensions like VHS depend on that behavior, because they catch those exceptions to specifically handle the file-not-found case.

Also mention the name of the missing file in the exception message to ease debugging.

Related: https://github.com/FluidTYPO3/vhs/issues/1725

cweiske commented 1 year ago

Is there anything preventing this from being merged @Lagerregal ?