search

andfoy / winpty-rs

Create and spawn processes inside a pseudoterminal in Windows from Rust
Other
23 stars 7 forks source link

PR: Let WaitForSingleObject return immediately #28

Closed andfoy closed 2 years ago

andfoy commented 2 years ago

The original value caused several synchronization issues

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (aea2230) into main (00321c7) will decrease coverage by 0.57%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   77.36%   76.79%   -0.58%     
==========================================
  Files           8        8              
  Lines        1224     1224              
==========================================
- Hits          947      940       -7     
- Misses        277      284       +7
Flag Coverage Δ
unittests 76.79% <100.00%> (-0.58%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pty/base.rs 71.70% <100.00%> (-2.53%) :arrow_down:
tests/conpty.rs 89.30% <0.00%> (+0.62%) :arrow_up:
tests/winpty.rs 98.57% <0.00%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00321c7...aea2230. Read the comment docs.