search

andfoy / winpty-rs

Create and spawn processes inside a pseudoterminal in Windows from Rust
Other
23 stars 7 forks source link

Prevent reading thread from hanging if process has stopped #79

Closed andfoy closed 1 month ago

andfoy commented 1 month ago

Fixes #72

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (1963287) to head (c36c7cd).

Files with missing lines Patch % Lines
src/pty/base.rs 75.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================== - Coverage 78.79% 78.66% -0.13% ========================================== Files 7 7 Lines 1240 1308 +68 ========================================== + Hits 977 1029 +52 - Misses 263 279 +16 ``` | [Flag](https://app.codecov.io/gh/andfoy/winpty-rs/pull/79/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+Andr%C3%A9s+Margffoy+Tuay) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/andfoy/winpty-rs/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+Andr%C3%A9s+Margffoy+Tuay) | `78.66% <94.20%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+Andr%C3%A9s+Margffoy+Tuay#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.