search

andfoy / winpty-rs

Create and spawn processes inside a pseudoterminal in Windows from Rust
Other
23 stars 7 forks source link

PR: Improve read performance and rewrite iseof #8

Closed andfoy closed 2 years ago

andfoy commented 2 years ago

This PR makes important changes to improve reading performance, as well as detecting if a process reached End-Of-Line.

codecov-commenter commented 2 years ago

Codecov Report

Merging #8 (da58d85) into main (e9886c1) will increase coverage by 2.54%. The diff coverage is 68.62%.

:exclamation: Current head da58d85 differs from pull request most recent head 4da0266. Consider uploading reports for the commit 4da0266 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   45.62%   48.16%   +2.54%     
==========================================
  Files           9       10       +1     
  Lines        1690     1823     +133     
==========================================
+ Hits          771      878     +107     
- Misses        919      945      +26
Flag Coverage Δ
unittests 48.16% <68.62%> (+2.54%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib.rs 0.85% <ø> (ø)
src/pty.rs 64.63% <25.00%> (-2.46%) :arrow_down:
src/pty/winpty/pty_impl.rs 77.77% <25.00%> (-1.39%) :arrow_down:
tests/conpty.rs 71.33% <50.00%> (+20.65%) :arrow_up:
src/pty/conpty/pty_impl.rs 70.49% <52.94%> (-1.13%) :arrow_down:
src/pty/base.rs 70.53% <74.23%> (-3.08%) :arrow_down:
src/pty/winpty/bindings.rs 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9886c1...4da0266. Read the comment docs.