andgineer / TRegExpr

Regular expressions (regex), pascal.
https://regex.sorokin.engineer/en/latest/
MIT License
174 stars 63 forks source link

Testframework for FPC doesn't exit with failure code #161

Open SlMaker opened 4 years ago

SlMaker commented 4 years ago

The FPC framework doesn't return the failure code (if error then exit code != 0) which always shows that the tests passed on Travis-CI.

Maybe use dunit/dunit2 for FPC instead?

masterandrey commented 4 years ago

+1 The test code actually from fpc project - I backported the tregexpr integration from freepascal scn. But obviously I broke something..

SlMaker commented 4 years ago

Maybe better use https://wiki.freepascal.org/FPTest src available on github https://github.com/graemeg/fptest so could be added to repo as reference

Alexey-T commented 2 years ago

I dont get idea what is requested here. Maybe close the issue? @andgineer

AmigoJack commented 1 year ago

The idea is that the test program should not exit with the value 0 when at least one assertion has failed. https://en.wikipedia.org/wiki/Exit_status speaks of what ExitCode in Pascal means - by default it is 0, indicating no failure.