inform user about non unique patient id in more explanatory way

[anandgavai]

This issue is resolved in the current version.

[mkuzak]

@anandgavai current version is HEAD master and and it's not fixed there, it's fixed in the pull request. Please if your commit messages close the issues, then once pull request is merged issues will be closed. Do not close issues on unmerged pull requests.

[anandgavai]

so when do we plan to merge pull request ?

[mkuzak]

once you resolve all the issues we discussed in the pull request.

[anandgavai]

Now it is fixed

[mkuzak]

Ok, validation works, but we need better, more meaningful feedback than just "duplicate". I'm renaming this issue to reflect that.

[Nanouk123]

You mean the feedback the user gets on having a duplicate needs to be more concrete?

Perhaps: "Not all subjects have a unique ID (print the conflicting ID). Please make sure all subjects have a unique ID before uploading your file".

Something like that?

[mkuzak]

Yes 👍 sth like that. When I read duplicate I might think I have same patient twice it does not point me to fixing the identifier which is an issue here.

[Nanouk123]

I agree, just print the conflicting ID's, its up to the user to figure out whether its an actual duplicate patient or just a duplicate ID number.

[anandgavai]

By print @Nanouk123 you mean we show a popup with conflicting id's ?

[Nanouk123]

The conflicting ID's should be ideally be displayed in the error message.

"Not all subjects have a unique ID ('Insert conflicting ID's separated by a comma'). Please make sure all subjects have a unique ID before uploading your file" ' Example: "Not all subjects have a unique ID (13,1108,6697). Please make sure all subjects have a unique ID before uploading your file"

[mkuzak]

closed by PR #57