search

andi-nl / ANDI-frontend

Advanced Neuropsychological Diagnostics Infrastructure frontend
1 stars 4 forks source link

tab2 give error after 5 patients #29

Closed anandgavai closed 8 years ago

anandgavai commented 8 years ago

Give error after 5 patients are manually added

mkuzak commented 8 years ago

Is this the same issue as #19 ?

mkuzak commented 8 years ago

Actually even though it does not through an error, it does not add another patient. The comment below If there exists more than 5 patients. Download this template... suggests this is expected behavior. What is the reason for limiting number of patients that can be input manually?

Nanouk123 commented 8 years ago

From our end there isnt (in an earlier 'wishlist' I asked for this to be removed). Clinicians should be able to decide for themselves how much they want to manually type in. Likewise you should be able to upload template data of one single patient.

JAvRZ commented 8 years ago

The 5 patients limit can be removed; especially if patients addition and deletion is managable with always visible test names. I think five patients may have come up as a theoretical limit of the number of patients that any user may have the patience for to fill them in, and if there is trouble fitting them on the screen, a limit may be necessary. But screen fitting solutions are definitely preferred over arbitrary limits.

anandgavai commented 8 years ago

I have removed the limit so this can be closed

mkuzak commented 8 years ago

Fixed in PR #53