search

andi-nl / ANDI-frontend

Advanced Neuropsychological Diagnostics Infrastructure frontend
1 stars 4 forks source link

Failure upon alphanumeric patient identifier #39

Closed ridderl closed 8 years ago

ridderl commented 8 years ago

When I entered data with patient identifier "p1", no plot appeared after "submit". Changing the identifier to an integer ("1"), keeping all other data the same, did succesfully result in a plot.

JAvRZ commented 8 years ago

Might have been due to R code, patient IDs were inexplicably forced to be numeric, which gave reproducible errors. New R-code in andi-webservices. Tested with patient ID "John" and I now see correct output once more. (I'm normally not this quick, I must admit).

mkuzak commented 8 years ago

@JAvRZ does that mean it's fixed now or not?

JAvRZ commented 8 years ago

I cannot be sure, Lars signaled the error using the interface, and I tried to fix the R code that could have been the issue (without breaking anything), but I do not know whether this was sufficient to fix the problem that Lars came across in the interface.

mkuzak commented 8 years ago

Ok, we'll have to test it once we have working interface again.

anandgavai commented 8 years ago

How would we test this ? for this we need to call teh webservice ?

mkuzak commented 8 years ago

On hold, until we have integrated web interface with webservice.

mkuzak commented 8 years ago

Could not reproduce that any more with current version. Closing.