search

andi-nl / ANDI-frontend

Advanced Neuropsychological Diagnostics Infrastructure frontend
1 stars 4 forks source link

Downloading, completing + uploading template didn't work #66

Closed ridderl closed 8 years ago

ridderl commented 8 years ago 
Demographics
id
age
sex
education
AVLT-total_1_to_5
AVLT-delayed_recall_1_to_5
AVLT-recognition_1_to_5
Demographics,Patient 1
id,2
age,45
sex,male
education,Verhage 2
AVLT-total_1_to_5,40
AVLT-delayed_recall_1_to_5,20
AVLT-recognition_1_to_5,10
Demographics
id
age
birthdate
testdate
sex
education
AVLT-total_1_to_5
AVLT-delayed_recall_1_to_5
AVLT-recognition_1_to_5
AVLT-total_1_to_5,40
AVLT-delayed_recall_1_to_5,20
AVLT-recognition_1_to_5,10
anandgavai commented 8 years ago

The uploading of data has been changed from "," separated values to Dutch standard ";" separated values.

ridderl commented 8 years ago

Ah, indeed with ; instead of , it works OK. But, I guess we want this to work with comma separated files as well? Also, after the upload, the button for (another) upload is gone. Is that on purpose?

ridderl commented 8 years ago

Also, the sex and education cells were still not filled

anandgavai commented 8 years ago

Sex needs to be 0, 1 and education needs to be values between 1 till 7 . The upload button was gone on request as it was a two step procedure, but will make it more clear.

ridderl commented 8 years ago
anandgavai commented 8 years ago

. @Nanouk123 is working on text for every tab and it will be made clear by me on the selection as well ! . Download after filling the table functionality never existed. It is only for creating the template to be filled in by the clinician

mkuzak commented 8 years ago

@ridderl this should work now (in running cloud instance) please confirm and close if you think it's resolved.

ridderl commented 8 years ago

No, it doesn't work properly yet:

mkuzak commented 8 years ago

Agree, does not work yet. @Nanouk123 do we want to be able to download template with filled in values?

anandgavai commented 8 years ago

If we want to have downloaded values then may be we can put this in a new requirement list ? @ridderl @Nanouk123 please confirm

Nanouk123 commented 8 years ago

@mkuzak at some point we do want to download the excel files with the values. Because then clinicians can store them with their results and reupload them later (that's why we have the 'upload template' in the first tab for these exact people).

I think some of these points overlap my comments on https://github.com/andi-nl/andi/issues/18#issuecomment-224606948 ?

mkuzak commented 8 years ago

@Nanouk123 @anandgavai @ridderl It's clear that this is a requirement then.

Nanouk123 commented 8 years ago

Yes, it already was in the beginning (idealy we wanted to export PDF with the results (plots) and automatically download the csv for the uploaded patient(s). This because we want clinicians to re-evaluate the patient data. But it was too much work and ethically difficult to instate a log in system in which clinicians could save the patient data they have filled out in earlier sessions.

So to avoid all that (you need permission from patients to keep their data online, security issues and such) we agreed that in the export you'd always include the excel/csv with the filled out data. So that for a next session they can quickly upload the file.

Does that make sense?

mkuzak commented 8 years ago

It does.

anandgavai commented 8 years ago

@Nanouk123 @ridderl If we would like to download template filled with values this would mean a lot of restructuring of the code !!!

Nanouk123 commented 8 years ago

This was already a requirement in the first version. We can discuss it later today if you wish.

mkuzak commented 8 years ago

This has been fixed or changed. Downloading data goes into the new tab. Template should always be empty.