search

andi-nl / ANDI-frontend

Advanced Neuropsychological Diagnostics Infrastructure frontend
1 stars 4 forks source link

After uplading data, button for upload disepears. #81

Closed mkuzak closed 8 years ago

mkuzak commented 8 years ago

When I upload data, I'm redirected to tab two, when I go back to tab one, upload button is gone and I cannot upload more data.

anandgavai commented 8 years ago

yes this is expected behaviour !

mkuzak commented 8 years ago

why?

anandgavai commented 8 years ago

this is to prevent user from uploading new data, I can make the upload available again if @Nanouk123 likes ?

mkuzak commented 8 years ago

@Nanouk123 @JAvRZ was it ever a requirement? What is the logic behind not allowing to upload multiple data files?

JAvRZ commented 8 years ago

I do not recognize it as a requirement, so I'm unsure about the logic. I think that the risk that the user does no longer know what file he is working with is very small. So I would not dynamically remove the button myself.

anandgavai commented 8 years ago

@JAvRZ some questions what should be the behaviour if the user uploads the same file with different values again ?

mkuzak commented 8 years ago

If the patient id is the same, data should be overwritten, otherwise it's different patient.

JAvRZ commented 8 years ago

I am not sure whether I would expect that behavior (I think I would expect: New file means new data, so overrides everything I have done so far). But I do like what you are saying Mateusz, that you can keep uploading patient files for different patients one by one (or if you want, overwrite one of the patients by entering the same ID). So I would think that would be better than what a cynical user like myself would expect.

anandgavai commented 8 years ago

@JAvRZ @Nanouk123 can add this to our new requirement list ?

mkuzak commented 8 years ago

I would make it an issue, it's not really a requirement.