search

andi-nl / ANDI-frontend

Advanced Neuropsychological Diagnostics Infrastructure frontend
1 stars 4 forks source link

Missing values are not removed for last patient #94

Closed JAvRZ closed 7 years ago

JAvRZ commented 8 years ago

If the values are outside the range (like 99999), this prohibits the user from going to the output as well. Screenshot should make it clear enough.

image

JAvRZ commented 8 years ago

I think this issue has changed. A missing value was introduced, but only for the first patient (I entered 60 as the missing value identifier, with two identical patients) image

However, in the visualisation, the changed variable I think was not made missing, but was replaced by nine 9s. image

So really, this issue seems to have split in a, only values for patient 1 are replaced, and b, missing values are not replaced with NA but are replaced with a very high value. This last issue I can probably fix in the andistats normcomp. Shall I, or is it better fixed before the opencpu/R step?

mkuzak commented 8 years ago

@JAvRZ wasn't the agreement that opencpu/R expects 999999999 instead of missing values?

JAvRZ commented 8 years ago

@mkuzak Okay, I changed the normcomp function to interpret 9 9's as NA's (and added a bit of much required functionality that you make multivariate comparisons with all scores not NA (one NA doesn't invalidate the whole multivariate procedure)). I'll wait with closing this issue, as I'm still not sure whether the website changes all "missing values" to 999999999, and not only for patient 1 (and of course the vm doesn't run this new normcomp just yet).

mkuzak commented 8 years ago

Update. Current status is that when there are missing values present but plots are not rendered. There is no error in the console.

mkuzak commented 7 years ago

The table has been rewritten. This is not an issue any more.