search

andi23rosca / solid-markdown

Render Markdown as Solid components
MIT License
106 stars 10 forks source link

Adding support for SSR #8

Closed hyenabyte closed 1 year ago

hyenabyte commented 1 year ago

Adding a build command that bundles for node instead of the browser, fixing the 'document is not defined' error

More here: https://github.com/wooorm/parse-entities/issues/19

mrshmllow commented 1 year ago

This PR works!

itsfolf commented 1 year ago

+1

AllStackDev1 commented 1 year ago

Can we merge this asap?

timothyallan commented 1 year ago

Is there something we can do to get this merged to use it in Solid Start?

andi23rosca commented 1 year ago

yep, my bad github is not notifying me for some stuff anymore 🤔

PatrickHeneise commented 1 year ago

Would appreciate an npm release with this patch

andi23rosca commented 1 year ago

version 1.2.1 is out 👍🏻

timothyallan commented 1 year ago

Hrmm, with 1.2.1 I get a [vite] Error when evaluating SSR module

An unhandled error occured: Error: Failed to resolve entry for package "solid-markdown". The package may have incorrect main/module/exports specified in its package.json

as soon as I have a import Markdown from 'solid-markdown'; statement in a standard Solid Start project.