Closed mhellmeier closed 2 years ago
There was a docker file added for review in the past, but I am not familiar with docker to be true. https://github.com/andreknieriem/photobooth/pull/180
I also checked that Dockerfile. It builds everything from scratch by using the debian:buster-slim
image. In my opinion, that's too complicated because other developers created scripts for that. Therefore, I used the webdevops/php-nginx
image that comes with a pre-build nginx server and PHP installed to reduce the maintenance overhead.
If you aren't familiar with docker you can have a look at the commands used in the Dockerfile
. I got them from the current installation script and the wiki.
I tested the whole setup and it works pretty well! I would be very happy to see it merged in the current dev
branch.
If you want to test it on your machine:
docker-compose up --build
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Add a docker setup for local testing and development to fix #396.
Is there anything you'd like reviewers to focus on?
No.